Skip to content

Remove zend json from weee #9261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2017
Merged

Remove zend json from weee #9261

merged 2 commits into from
Apr 19, 2017

Conversation

@dmanners
Copy link
Contributor

@dmanners dmanners commented Apr 15, 2017 •
edited by okorshenko
Loading

Description

Since Zend Framework 1 is at end of life we should remove the usage of Zend_Json. This review is part of #9236

Fixed Issues (if relevant)

  1. Upgrade ZF components. Zend_Json #9236: Upgrade ZF components. Zend_Json (Part fix)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners
Copy link
Contributor Author

dmanners commented Apr 15, 2017

I was seeing issues with some test cases under /Magento/Weee/Test/Unit/Model/Attribute/Backend/Weee/TaxTest.php it seems that

magento2/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Price.php

Line 77 in 99e85cb

$this->scopeOverriddenValue = $scopeOverriddenValue
is causing issues as this is the tax model's parent but the tax model does not deal with the attribute ScopeOverriddenValue

@okorshenko okorshenko self-assigned this Apr 17, 2017
@okorshenko okorshenko added this to the April 2017 milestone Apr 17, 2017
@okorshenko
Copy link
Contributor

okorshenko commented Apr 19, 2017

@dmanners thank you for reporting about Magento/Weee/Test/Unit/Model/Attribute/Backend/Weee/TaxTest.php. We will fix it

@magento-team magento-team merged commit f327e9e into magento:develop Apr 19, 2017
magento-team pushed a commit that referenced this pull request Apr 19, 2017
MAGETWO-67510: Remove zend json from weee #9261
3c696b6 
 - fixed incorrect constructor in Tax model
magento-team pushed a commit that referenced this pull request Apr 19, 2017
MAGETWO-67510: Remove zend json from weee #9261
f36ef99 
 - fixed static test
magento-team pushed a commit that referenced this pull request Apr 19, 2017
MAGETWO-67510: Remove zend json from weee #9261
c4f4e29
magento-team pushed a commit that referenced this pull request Apr 19, 2017
MAGETWO-67510: Remove zend json from weee #9261
c5a94c8 
 - fixed static test
@magento-team
Copy link
Contributor

magento-team commented Apr 19, 2017

@dmanners thank you for your contribution to Magento 2 project

@dmanners dmanners deleted the remove-zend-json-from-weee branch July 26, 2017 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@okorshenko okorshenko

Labels

improvement Progress: accept

Projects

None yet

Milestone

April 2017

Development

Successfully merging this pull request may close these issues.

3 participants

@dmanners @okorshenko @magento-team